-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(home): stats section #9
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
The Figma design has the hero image at 500px wide. I've tested on Chrome & Safari and noticed that the hero image width is 464px |
OOC, does the stats call use SSR? If the scraper has any issues, what would be the timeout before the user is served data? If there's a timeout, we may want to render this client-side since it's not critical for painting the rest of the page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment
Fixed a18c51b |
The
This use case is the perfect fit for Server Components IMO. There is no need to render the data client-side and create a delay/loading state in the UI. If the request fails during build time, Next.js uses the previously cached value and retries on the next validation cycle. It was helpful for me to read through these docs in order to understand App Router and Server Components better: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I read through the SSR docs +1
Based on #8
Closes ACX-1868