Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(home): stats section #9

Merged
merged 22 commits into from
Feb 14, 2024
Merged

feat(home): stats section #9

merged 22 commits into from
Feb 14, 2024

Conversation

dohaki
Copy link
Collaborator

@dohaki dohaki commented Feb 12, 2024

Based on #8

Closes ACX-1868

Copy link

linear bot commented Feb 12, 2024

Copy link

vercel bot commented Feb 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
across-to ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2024 9:46am

@james-a-morris
Copy link
Contributor

The Figma design has the hero image at 500px wide. I've tested on Chrome & Safari and noticed that the hero image width is 464px

@james-a-morris
Copy link
Contributor

OOC, does the stats call use SSR?

If the scraper has any issues, what would be the timeout before the user is served data? If there's a timeout, we may want to render this client-side since it's not critical for painting the rest of the page.

Copy link
Contributor

@james-a-morris james-a-morris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment

Base automatically changed from home-tech-section to master February 13, 2024 09:15
@dohaki
Copy link
Collaborator Author

dohaki commented Feb 13, 2024

The Figma design has the hero image at 500px wide. I've tested on Chrome & Safari and noticed that the hero image width is 464px

Fixed a18c51b

@dohaki
Copy link
Collaborator Author

dohaki commented Feb 13, 2024

OOC, does the stats call use SSR?

The <StatsSection /> component is a Server Component and is rendered on the server, yes. Per default this happens during build time and statically though.

If the scraper has any issues, what would be the timeout before the user is served data? If there's a timeout, we may want to render this client-side since it's not critical for painting the rest of the page.

This use case is the perfect fit for Server Components IMO. There is no need to render the data client-side and create a delay/loading state in the UI. If the request fails during build time, Next.js uses the previously cached value and retries on the next validation cycle.

It was helpful for me to read through these docs in order to understand App Router and Server Components better:

Copy link
Contributor

@james-a-morris james-a-morris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I read through the SSR docs +1

@dohaki dohaki merged commit 65ca23c into master Feb 14, 2024
4 checks passed
@dohaki dohaki deleted the home-stats-section branch February 14, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants